Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 11015019: Handle "is" and "as" like other keywords. (Closed)

Created:
8 years, 2 months ago by ahe
Modified:
8 years, 2 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, Anton Muhin, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Handle "is" and "as" like other keywords. Committed: https://code.google.com/p/dart/source/detail?r=13065

Patch Set 1 #

Patch Set 2 : Also a few co19 fixes in dart2js. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M dart/lib/compiler/implementation/scanner/keyword.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M dart/lib/compiler/implementation/scanner/token.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M dart/tests/co19/co19-dart2dart.status View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/co19/co19-dart2js.status View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
8 years, 2 months ago (2012-10-01 12:57:32 UTC) #1
Johnni Winther
lgtm
8 years, 2 months ago (2012-10-01 13:10:29 UTC) #2
ahe
Also fixed a few co19 tests for dart2js.
8 years, 2 months ago (2012-10-01 13:27:27 UTC) #3
Johnni Winther
8 years, 2 months ago (2012-10-01 13:54:03 UTC) #4
Still LGTM

Powered by Google App Engine
This is Rietveld 408576698