Issue 11014022: Make Mirror.simpleName unique.

Issue 11014022: Make Mirror.simpleName unique. (Closed)

Created:
8 years, 2 months ago by Johnni Winther

Modified:
8 years, 2 months ago

Reviewers:
Lasse Reichstein Nielsen, ngeoffray

CC:
reviews_dartlang.org, turnidge, gbracha

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make Mirror.simpleName unique. Committed: https://code.google.com/p/dart/source/detail?r=13167

Patch Set 2 : findMirror removed #

Patch Set 4 : Updated cf. comments. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+199 lines, -196 lines)			Patch
M	pkg/dartdoc/lib/dartdoc.dart	View	1 2 3	11 chunks	+19 lines, -53 lines	0 comments	Download
M	pkg/dartdoc/lib/mirrors.dart	View	1 2 3	6 chunks	+29 lines, -10 lines	0 comments	Download
M	pkg/dartdoc/lib/mirrors_util.dart	View	1	2 chunks	+1 line, -29 lines	0 comments	Download
M	pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart	View	1 2 3	26 chunks	+82 lines, -84 lines	0 comments	Download
M	pkg/dartdoc/lib/src/mirrors/util.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/mirrors_test.dart	View	1 2 3	14 chunks	+63 lines, -18 lines	0 comments	Download
M	utils/apidoc/html_diff.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM http://codereview.chromium.org/11014022/diff/3008/pkg/dartdoc/lib/mirrors.dart File pkg/dartdoc/lib/mirrors.dart (right): http://codereview.chromium.org/11014022/diff/3008/pkg/dartdoc/lib/mirrors.dart#newcode72 pkg/dartdoc/lib/mirrors.dart:72: * The simple name is in most cases ...

8 years, 2 months ago (2012-10-02 20:19:42 UTC) #2

Johnni Winther

8 years, 2 months ago (2012-10-03 09:36:24 UTC) #3

https://codereview.chromium.org/11014022/diff/3008/pkg/dartdoc/lib/mirrors.dart
File pkg/dartdoc/lib/mirrors.dart (right):

https://codereview.chromium.org/11014022/diff/3008/pkg/dartdoc/lib/mirrors.da...
pkg/dartdoc/lib/mirrors.dart:72: * The simple name is in most cases the the
declared single identifier name of
On 2012/10/02 20:19:43, ngeoffray wrote:
> the the -> the

Done.

https://codereview.chromium.org/11014022/diff/3008/pkg/dartdoc/lib/mirrors.da...
pkg/dartdoc/lib/mirrors.dart:85: * The display name is normal representation of
the entity name. In most cases
On 2012/10/02 20:19:43, ngeoffray wrote:
> is normal -> is the normal

Done.

https://codereview.chromium.org/11014022/diff/3008/tests/compiler/dart2js/mir...
File tests/compiler/dart2js/mirrors_test.dart (right):

https://codereview.chromium.org/11014022/diff/3008/tests/compiler/dart2js/mir...
tests/compiler/dart2js/mirrors_test.dart:31: foundMirror = mirror;
On 2012/10/02 20:19:43, ngeoffray wrote:
> Can it have duplicates and then you take the last occurrence? Otherwise you
> could use a for loop with a break.

Done.

Expand Messages | Collapse Messages