Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 11014020: Pack deopt ID into the return before and return after deopt instructions. (Closed)

Created:
8 years, 2 months ago by Kevin Millikin (Google)
Modified:
8 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Pack deopt ID into the return before and return after deopt instructions. Pack it into a machine word-sized bit field along with the object table index. The commands do not implicitly use the object table index any more, which allows removing deopt IDs from the object table and pooling function entries. R=srdjan@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13214

Patch Set 1 #

Total comments: 3

Patch Set 2 : Incorporated review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -30 lines) Patch
M runtime/vm/deopt_instructions.cc View 1 4 chunks +47 lines, -29 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Kevin Millikin (Google)
8 years, 2 months ago (2012-10-02 06:15:28 UTC) #1
srdjan
https://codereview.chromium.org/11014020/diff/1/runtime/vm/deopt_instructions.cc File runtime/vm/deopt_instructions.cc (right): https://codereview.chromium.org/11014020/diff/1/runtime/vm/deopt_instructions.cc#newcode140 runtime/vm/deopt_instructions.cc:140: } How about overloading constructor with: DeoptRetAddrAfterInstr(intptr_t from_index), thus ...
8 years, 2 months ago (2012-10-02 17:34:49 UTC) #2
Kevin Millikin (Google)
https://codereview.chromium.org/11014020/diff/1/runtime/vm/deopt_instructions.cc File runtime/vm/deopt_instructions.cc (right): https://codereview.chromium.org/11014020/diff/1/runtime/vm/deopt_instructions.cc#newcode140 runtime/vm/deopt_instructions.cc:140: } On 2012/10/02 17:34:49, srdjan wrote: > How about ...
8 years, 2 months ago (2012-10-03 07:05:36 UTC) #3
Kevin Millikin (Google)
Comments addressed. Please take another look.
8 years, 2 months ago (2012-10-03 14:10:43 UTC) #4
srdjan
8 years, 2 months ago (2012-10-03 15:33:51 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698