Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1101343004: Fix all the analysis hints in pub. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -96 lines) Patch
M sdk/lib/_internal/pub/lib/src/ascii_tree.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart View 7 chunks +12 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/dart_forwarding_transformer.dart View 1 chunk +1 line, -4 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/build.dart View 2 chunks +11 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/global_deactivate.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/global_list.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/serve.dart View 4 chunks +8 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command_runner.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/global_packages.dart View 4 chunks +3 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/http.dart View 2 chunks +1 line, -9 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/io.dart View 2 chunks +1 line, -7 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/oauth2.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/pubspec.dart View 3 chunks +0 lines, -12 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/version_solver.dart View 1 chunk +0 lines, -29 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/dependency.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/license.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/name.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/sdk_constraint.dart View 1 chunk +0 lines, -4 lines 0 comments Download
A sdk/lib/_internal/pub/test/dart2js/environment_constant_test.dart View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 8 months ago (2015-04-24 21:42:45 UTC) #1
Bob Nystrom
LGTM!
5 years, 8 months ago (2015-04-24 22:10:57 UTC) #2
nweiz
5 years, 7 months ago (2015-05-04 20:50:29 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 45508 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698