Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1101083003: Fixes to enable building dart io implementation in mojo tree (Closed)

Created:
5 years, 8 months ago by Cutch
Modified:
5 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fixes to enable building dart:io implementation cleanly in mojo tree + make Observatory respect script line offsets (which Sky uses). R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45427

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M runtime/bin/bin.gypi View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/filter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 1 2 3 4 chunks +9 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 4 chunks +6 lines, -2 lines 0 comments Download
M runtime/platform/assert.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/platform/globals.h View 4 chunks +10 lines, -3 lines 1 comment Download
M runtime/vm/object.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 8 months ago (2015-04-26 19:11:42 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/1101083003/diff/60001/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/1101083003/diff/60001/runtime/platform/globals.h#newcode382 runtime/platform/globals.h:382: #if !defined(DISALLOW_COPY_AND_ASSIGN) Where are these coming from ...
5 years, 8 months ago (2015-04-27 04:49:35 UTC) #3
Cutch
On 2015/04/27 04:49:35, Ivan Posva wrote: > LGTM -ip > > https://codereview.chromium.org/1101083003/diff/60001/runtime/platform/globals.h > File runtime/platform/globals.h ...
5 years, 8 months ago (2015-04-27 14:46:16 UTC) #4
Cutch
5 years, 8 months ago (2015-04-27 14:46:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 45427 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698