Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1100873005: Add a --reporter flag and expose the expanded reporter. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a --reporter flag and expose the expanded reporter. Windows now uses the expanded reporter by default, since it doesn't support using \r to go to the beginning of the line. Closes #85 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/543d9f3988ed96c6444ec30ff3d169b4d3ca89f9

Patch Set 1 #

Total comments: 6

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -310 lines) Patch
M CHANGELOG.md View 1 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/executable.dart View 1 3 chunks +15 lines, -2 lines 0 comments Download
M lib/src/runner/engine.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/src/runner/reporter/compact.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + lib/src/runner/reporter/expanded.dart View 1 7 chunks +25 lines, -15 lines 0 comments Download
D lib/src/runner/reporter/no_io_compact.dart View 1 chunk +0 lines, -241 lines 0 comments Download
M lib/test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/runner/browser/compact_reporter_test.dart View 1 chunk +11 lines, -2 lines 0 comments Download
A + test/runner/browser/expanded_reporter_test.dart View 1 chunk +11 lines, -2 lines 0 comments Download
M test/runner/compact_reporter_test.dart View 2 chunks +6 lines, -3 lines 0 comments Download
A + test/runner/expanded_reporter_test.dart View 14 chunks +8 lines, -41 lines 0 comments Download
M test/runner/runner_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 8 months ago (2015-04-22 23:35:39 UTC) #1
kevmoo
LGTM modulo nits https://codereview.chromium.org/1100873005/diff/1/lib/src/runner/reporter/expanded.dart File lib/src/runner/reporter/expanded.dart (right): https://codereview.chromium.org/1100873005/diff/1/lib/src/runner/reporter/expanded.dart#newcode83 lib/src/runner/reporter/expanded.dart:83: ExpandedReporter(Iterable<Suite> suites, {int concurrency, bool color: ...
5 years, 8 months ago (2015-04-23 00:13:15 UTC) #2
nweiz
Code review changes
5 years, 8 months ago (2015-04-23 00:15:39 UTC) #3
nweiz
https://codereview.chromium.org/1100873005/diff/1/lib/src/runner/reporter/expanded.dart File lib/src/runner/reporter/expanded.dart (right): https://codereview.chromium.org/1100873005/diff/1/lib/src/runner/reporter/expanded.dart#newcode83 lib/src/runner/reporter/expanded.dart:83: ExpandedReporter(Iterable<Suite> suites, {int concurrency, bool color: true}) On 2015/04/23 ...
5 years, 8 months ago (2015-04-23 00:15:52 UTC) #4
nweiz
5 years, 8 months ago (2015-04-23 00:16:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
543d9f3988ed96c6444ec30ff3d169b4d3ca89f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698