Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1100393004: add dart: and package: import uri suggestions (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

add dart: and package: import uri suggestions BUG=dartbug.com/23073 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45398

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -6 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 2 chunks +4 lines, -2 lines 0 comments Download
A pkg/analysis_server/lib/src/services/completion/import_uri_contributor.dart View 1 chunk +134 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analysis_server/test/services/completion/import_uri_contributor_test.dart View 1 chunk +119 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 8 months ago (2015-04-23 22:58:55 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-04-23 23:21:02 UTC) #3
danrubel
5 years, 8 months ago (2015-04-24 12:52:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45398 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698