Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1100073002: Allow access to type variables as expressions in factory constructors. (Closed)

Created:
5 years, 8 months ago by karlklose
Modified:
5 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Allow access to type variables as expressions in factory constructors. BUG= http://dartbug.com/22700 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=45328

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
5 years, 8 months ago (2015-04-22 08:59:17 UTC) #1
Johnni Winther
lgtm
5 years, 8 months ago (2015-04-22 09:09:09 UTC) #2
karlklose
5 years, 8 months ago (2015-04-22 09:11:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45328 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698