Issue 11000049: Add progress indicator for co19 updating.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11000049: Add progress indicator for co19 updating. (Closed)

Created:
8 years, 2 months ago by ahe

Modified:
8 years, 2 months ago

Reviewers:
Bill Hesse, Mads Ager (google), kasperl

CC:
reviews_dartlang.org, Mads Ager (google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add progress indicator for co19 updating. Committed: https://code.google.com/p/dart/source/detail?r=13008

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -6 lines)			Patch
	M	dart/tools/testing/dart/co19_test.dart	View		3 chunks	+3 lines, -6 lines	0 comments	Download
	M	dart/tools/testing/dart/test_progress.dart	View		2 chunks	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years, 2 months ago (2012-09-28 12:09:55 UTC) #2

LGTM

I wonder if we should consider making something like this the default. I don't
like the way the test scripts now print all failures in exactly the same way
twice. First when you get to the failure and all of them again at the end. Bill
probably remember why we did it that way, but I find it annoying. :-)

Expand Messages | Collapse Messages