Issue 11000031: Copy README.dart-sdk to dart-sdk/README .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11000031: Copy README.dart-sdk to dart-sdk/README . (Closed)

Created:
8 years, 2 months ago by dgrove

Modified:
8 years, 2 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Copy README.dart-sdk to dart-sdk/README . Use this opportunity to get rid of create.stamp, and use the README file as a marker for the build. Fixes issue 2062 and is the last piece of fixing issue 4129. Committed: https://code.google.com/p/dart/source/detail?r=12980

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	dart.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	tools/create_sdk.py	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/11000031/diff/1/tools/create_sdk.py File tools/create_sdk.py (right): https://codereview.chromium.org/11000031/diff/1/tools/create_sdk.py#newcode329 tools/create_sdk.py:329: Copy(join(HOME, 'README.dart-sdk'), join(SDK_tmp, 'README')) will this update the time-stamp ...

8 years, 2 months ago (2012-09-27 17:57:59 UTC) #2

dgrove

On 2012/09/27 17:57:59, sigmund wrote: > https://codereview.chromium.org/11000031/diff/1/tools/create_sdk.py > File tools/create_sdk.py (right): > > https://codereview.chromium.org/11000031/diff/1/tools/create_sdk.py#newcode329 > ...

8 years, 2 months ago (2012-09-27 18:01:21 UTC) #3

lgtm

Expand Messages | Collapse Messages