Issue 11000025: Revert hiding of VM-only coreimpl list implementation types. While I

Issue 11000025: Revert hiding of VM-only coreimpl list implementation types. While I (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)

Modified:
8 years, 2 months ago

Reviewers:
Florian Schneider, srdjan, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert hiding of VM-only coreimpl list implementation types. While I investigate performance regression (even after fixing constructors in the intrinsifier). R=iposva@google.com,srdjan@google.com,fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12963

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+341 lines, -223 lines)			Patch
M	lib/compiler/implementation/lib/io.dart	View	2 chunks	+1 line, -35 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/src/native_DOMImplementation.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/builtin_impl_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/builtin_natives.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	runtime/bin/common.cc	View	1 chunk	+0 lines, -28 lines	0 comments	Download
M	runtime/bin/common.dart	View	2 chunks	+0 lines, -40 lines	0 comments	Download
M	runtime/bin/file_impl.dart	View	3 chunks	+30 lines, -2 lines	0 comments	Download
M	runtime/bin/process_impl.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/socket_impl.dart	View	1 chunk	+22 lines, -2 lines	0 comments	Download
M	runtime/lib/array.dart	View	12 chunks	+17 lines, -19 lines	0 comments	Download
M	runtime/lib/array_patch.dart	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	runtime/lib/byte_array.dart	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	8 chunks	+18 lines, -18 lines	0 comments	Download
M	runtime/lib/immutable_map.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/lib/literal_factory.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/string_base.dart	View	5 chunks	+9 lines, -9 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intrinsifier.h	View	1 chunk	+17 lines, -19 lines	0 comments	Download
M	runtime/vm/intrinsifier.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	3 chunks	+6 lines, -8 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/corelib/growable_object_array2_vm_test.dart	View	1 chunk	+74 lines, -0 lines	0 comments	Download
A	tests/corelib/growable_object_array_vm_test.dart	View	1 chunk	+113 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years, 2 months ago (2012-09-27 14:10:26 UTC) #1

Reverting all of it as performance did not come back after intrinsifier fix.

Expand Messages | Collapse Messages