Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 11000021: Intrinsify named constructors on private classes. (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Intrinsify named constructors on private classes. This was broken before my GrowableArray change as well for the _Double.fromInteger constructor. This is using the fact that named constructors are the only method names that contain '.'. Therefore, it is enough to check that the classes match and that the method name starting at the '.' matches. R=srdjan@google.com,iposva@google.com,fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M runtime/vm/intrinsifier.h View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 2 months ago (2012-09-27 13:33:46 UTC) #1
Mads Ager (google)
8 years, 2 months ago (2012-09-27 13:36:59 UTC) #2
TBR to fix performance.

I'll keep an eye on everything. Performance and buildbots.

Powered by Google App Engine
This is Rietveld 408576698