Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 11000018: Correctly mark scalarlists as abstract classes with factory (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)
Modified:
8 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Correctly mark scalarlists as abstract classes with factory constructors. The marking as abstract avoids warnings about non-implemented inherited methods for the scalarlists on construction. Once the classes are abstract the constructors have to be factory constructors which they are anyway. R=sgjesse@google.com BUG=dartbug.com/5469 Committed: https://code.google.com/p/dart/source/detail?r=12951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M lib/scalarlist/byte_arrays.dart View 20 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 2 months ago (2012-09-27 12:30:18 UTC) #1
Søren Gjesse
8 years, 2 months ago (2012-09-27 12:31:16 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698