Issue 1099633004: Fix error handling for formatting and update the spec

Issue 1099633004: Fix error handling for formatting and update the spec (Closed)

Created:
5 years, 8 months ago by Brian Wilkerson

Modified:
5 years, 8 months ago

Reviewers:
scheglov, jwren

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix error handling for formatting and update the spec R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45296

Patch Set 1 #

Total comments: 1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -20 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/AnalysisServer.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RequestErrorCode.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	3 chunks	+10 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	4 chunks	+9 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/protocol.dart	View	1 chunk	+10 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/edit/format_test.dart	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/integration/integration_test_methods.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	2 chunks	+13 lines, -5 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

Committed patchset #1 (id:1) manually as 45296 (presubmit successful).

5 years, 8 months ago (2015-04-20 20:57:46 UTC) #4

jwren

5 years, 8 months ago (2015-04-20 21:01:52 UTC) #5

Message was sent while issue was closed.

LGTM.

https://codereview.chromium.org/1099633004/diff/1/pkg/analysis_server/tool/sp...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/1099633004/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:8: <h1
style="color:#999999">Version <version>1.6.1</version></h1>
Need to increment this so that the clients can know if the new error can be
returned/ is part of the API.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages