Issue 10996057: Instruction size and growth threshold for inlining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10996057: Instruction size and growth threshold for inlining. (Closed)

Created:
8 years, 2 months ago by zerny-google

Modified:
8 years, 2 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -7 lines)			Patch
M	runtime/vm/flow_graph.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1	8 chunks	+48 lines, -7 lines	0 comments	Download

Total messages: 5 (0 generated)

srdjan

8 years, 2 months ago (2012-10-01 20:39:47 UTC) #5

On 2012/09/28 10:22:00, kmillikin wrote:
> lgtm

This CL has reduced the performance of Richards by 13% on ia32. Could you please
investigate?