Issue 10996036: Quick fixes 'Create class' and 'Create constructor'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10996036: Quick fixes 'Create class' and 'Create constructor' (Closed)

Created:
8 years, 2 months ago by scheglov

Modified:
8 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Quick fixes 'Create class' and 'Create constructor' http://code.google.com/p/dart/issues/detail?id=5325 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12953

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+376 lines, -85 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/DartClass.java	View	5 chunks	+22 lines, -6 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	2 chunks	+25 lines, -18 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ClassElement.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java	View	3 chunks	+16 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ClassElementUnion.java	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/AST.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/ClassCompleter.java	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/CorrectionMessages.java	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/CorrectionMessages.properties	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java	View	11 chunks	+178 lines, -41 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/correction/QuickFixProcessorTest.java	View	7 chunks	+92 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 2 months ago (2012-09-27 01:57:56 UTC) #2

LGTM

https://codereview.chromium.org/10996036/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java
(right):

https://codereview.chromium.org/10996036/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java:277:
// XXX
Out of curiosity, what is this comment for?

Expand Messages | Collapse Messages