Issue 10996002: Fix snapshot reading of canonicalized types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10996002: Fix snapshot reading of canonicalized types. (Closed)

Created:
8 years, 2 months ago by regis

Modified:
8 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix snapshot reading of canonicalized types. Change some redirecting factory compile-time errors into dynamic errors after discussion with Gilad (negative tests still missing). Committed: https://code.google.com/p/dart/source/detail?r=12872

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -29 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1	4 chunks	+27 lines, -19 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	3 chunks	+7 lines, -1 line	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1	3 chunks	+13 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/10996002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/10996002/diff/1/runtime/vm/object.cc#newcode3656 runtime/vm/object.cc:3656: } Should we have an assert here: ASSERT(IsInstantiated()); ...

8 years, 2 months ago (2012-09-25 18:55:45 UTC) #2

regis

8 years, 2 months ago (2012-09-25 19:26:25 UTC) #3

Thanks!

https://codereview.chromium.org/10996002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/10996002/diff/1/runtime/vm/object.cc#newcode3656
runtime/vm/object.cc:3656: }
On 2012/09/25 18:55:45, siva wrote:
> Should we have an assert here:
> 
> ASSERT(IsInstantiated());
> 
> In other words can we Canonicalize if it has not been instantiated.

It is not a problem to canonicalize an uninstantiated type argument vector. It
only means that it contains a type parameter. I am not sure why this test was
there in the first place.

Expand Messages | Collapse Messages