Stop using the Hashable interface.

Stop using the Hashable interface.

All objects have a hashCode method, so there is no need for a Hashable
interface.
The interface itself is retained for at least two weeks, to give time for
code to remove uses of it.

Committed: https://code.google.com/p/dart/source/detail?r=12955

[Lasse Reichstein Nielsen, 2012-09-27 12:42:36]

https://codereview.chromium.org/10993059/diff/1/lib/compiler/implementation/c...
File lib/compiler/implementation/constants.dart (right):

https://codereview.chromium.org/10993059/diff/1/lib/compiler/implementation/c...
lib/compiler/implementation/constants.dart:19: class Constant  {
Whoops, double space. Will fix.

[Mads Ager (google), 2012-09-27 12:48:27]

LGTM, with tons of single spaces removed. :-)

https://codereview.chromium.org/10993059/diff/1/lib/compiler/implementation/c...
File lib/compiler/implementation/constants.dart (right):

https://codereview.chromium.org/10993059/diff/1/lib/compiler/implementation/c...
lib/compiler/implementation/constants.dart:19: class Constant  {
Remove extra space before '{'.

https://codereview.chromium.org/10993059/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://codereview.chromium.org/10993059/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:5: class
LocalPlaceholder  {
Ditto.

https://codereview.chromium.org/10993059/diff/1/lib/compiler/implementation/t...
File lib/compiler/implementation/typechecker.dart (right):

https://codereview.chromium.org/10993059/diff/1/lib/compiler/implementation/t...
lib/compiler/implementation/typechecker.dart:27: abstract class DartType  {
Remove extra space.

https://codereview.chromium.org/10993059/diff/1/lib/compiler/implementation/u...
File lib/compiler/implementation/universe/universe.dart (right):

https://codereview.chromium.org/10993059/diff/1/lib/compiler/implementation/u...
lib/compiler/implementation/universe/universe.dart:122: class Selector  {
Ditto.

https://codereview.chromium.org/10993059/diff/1/lib/core/hashable.dart
File lib/core/hashable.dart (right):

https://codereview.chromium.org/10993059/diff/1/lib/core/hashable.dart#newcode11
lib/core/hashable.dart:11: * after a grace period. Code that use the
[:Hashable:] interface should just
that uses

should just -> should

I assume you are going to send out a breaking change mail to the mailing list
with this once this lands?

Please add a TODO with a bug number for a M2 bug so we make sure this is
removed.

https://codereview.chromium.org/10993059/diff/1/lib/coreimpl/hash_map_set.dart
File lib/coreimpl/hash_map_set.dart (right):

https://codereview.chromium.org/10993059/diff/1/lib/coreimpl/hash_map_set.dar...
lib/coreimpl/hash_map_set.dart:279: class HashSetImplementation<E > implements
HashSet<E> {
Extra space.

https://codereview.chromium.org/10993059/diff/1/lib/isolate/base.dart
File lib/isolate/base.dart (right):

https://codereview.chromium.org/10993059/diff/1/lib/isolate/base.dart#newcode53
lib/isolate/base.dart:53: abstract class SendPort  {
Ditto.

https://codereview.chromium.org/10993059/diff/1/lib/mirrors/mirrors.dart
File lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/10993059/diff/1/lib/mirrors/mirrors.dart#newc...
lib/mirrors/mirrors.dart:85: abstract class Mirror  {
Ditto.

https://codereview.chromium.org/10993059/diff/1/pkg/dartdoc/lib/mirrors.dart
File pkg/dartdoc/lib/mirrors.dart (right):

https://codereview.chromium.org/10993059/diff/1/pkg/dartdoc/lib/mirrors.dart#...
pkg/dartdoc/lib/mirrors.dart:65: abstract class Mirror  {
Ditto.

https://codereview.chromium.org/10993059/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

https://codereview.chromium.org/10993059/diff/1/runtime/bin/http_impl.dart#ne...
runtime/bin/http_impl.dart:1200: class _HttpConnectionBase  {
space.

https://codereview.chromium.org/10993059/diff/1/runtime/bin/path.dart
File runtime/bin/path.dart (right):

https://codereview.chromium.org/10993059/diff/1/runtime/bin/path.dart#newcode12
runtime/bin/path.dart:12: abstract class Path  {
space.

https://codereview.chromium.org/10993059/diff/1/runtime/bin/socket.dart
File runtime/bin/socket.dart (right):

https://codereview.chromium.org/10993059/diff/1/runtime/bin/socket.dart#newco...
runtime/bin/socket.dart:37: abstract class Socket  {
space

https://codereview.chromium.org/10993059/diff/1/runtime/bin/websocket.dart
File runtime/bin/websocket.dart (right):

https://codereview.chromium.org/10993059/diff/1/runtime/bin/websocket.dart#ne...
runtime/bin/websocket.dart:60: abstract class WebSocketConnection  {
guess what. In the rest of the file as well.

https://codereview.chromium.org/10993059/diff/1/tests/corelib/set_iterator_te...
File tests/corelib/set_iterator_test.dart (right):

https://codereview.chromium.org/10993059/diff/1/tests/corelib/set_iterator_te...
tests/corelib/set_iterator_test.dart:5: class FixedHashCode  {
hep

https://codereview.chromium.org/10993059/diff/1/tests/language/core_type_chec...
File tests/language/core_type_check_test.dart (right):

https://codereview.chromium.org/10993059/diff/1/tests/language/core_type_chec...
tests/language/core_type_check_test.dart:15: class B  {
hep

https://codereview.chromium.org/10993059/diff/1/tests/language/savannah_test....
File tests/language/savannah_test.dart (right):

https://codereview.chromium.org/10993059/diff/1/tests/language/savannah_test....
tests/language/savannah_test.dart:6: abstract class BigGame  {
hep

https://codereview.chromium.org/10993059/diff/1/tests/language/type_parameter...
File tests/language/type_parameter_test.dart (right):

https://codereview.chromium.org/10993059/diff/1/tests/language/type_parameter...
tests/language/type_parameter_test.dart:5: class A<T > {
hep

https://codereview.chromium.org/10993059/diff/1/utils/pub/yaml/model.dart
File utils/pub/yaml/model.dart (right):

https://codereview.chromium.org/10993059/diff/1/utils/pub/yaml/model.dart#new...
utils/pub/yaml/model.dart:10: class _Tag  {
hep

https://codereview.chromium.org/10993059/diff/1/utils/pub/yaml/model.dart#new...
utils/pub/yaml/model.dart:53: class _Node  {
hep

https://codereview.chromium.org/10993059/diff/1/utils/pub/yaml/yaml_map.dart
File utils/pub/yaml/yaml_map.dart (right):

https://codereview.chromium.org/10993059/diff/1/utils/pub/yaml/yaml_map.dart#...
utils/pub/yaml/yaml_map.dart:65: class _WrappedHashKey  {
hep

[Lasse Reichstein Nielsen, 2012-09-27 13:59:36]

https://codereview.chromium.org/10993059/diff/1/lib/core/hashable.dart
File lib/core/hashable.dart (right):

https://codereview.chromium.org/10993059/diff/1/lib/core/hashable.dart#newcode11
lib/core/hashable.dart:11: * after a grace period. Code that use the
[:Hashable:] interface should just
On 2012/09/27 12:48:27, Mads Ager wrote:
> I assume you are going to send out a breaking change mail to the mailing list
> with this once this lands?

Absolutely.

> Please add a TODO with a bug number for a M2 bug so we make sure this is
removed.

Done.