Implement the apply functionality for dart2js and currently just put it in a test.

Implement the apply functionality for dart2js and currently just put it in a test.
Committed: https://code.google.com/p/dart/source/detail?r=12909

[kasperl, 2012-09-26 13:23:43]

LGTM.

https://codereview.chromium.org/10993036/diff/2001/tests/compiler/dart2js_nat...
File tests/compiler/dart2js_native/apply_test.dart (right):

https://codereview.chromium.org/10993036/diff/2001/tests/compiler/dart2js_nat...
tests/compiler/dart2js_native/apply_test.dart:9: int nbArguments = 0;
nbArguments -> argumentCount?

https://codereview.chromium.org/10993036/diff/2001/tests/compiler/dart2js_nat...
tests/compiler/dart2js_native/apply_test.dart:19: // arguments order.
Maybe add a comment that explains why you've decided on using JS sorting?

https://codereview.chromium.org/10993036/diff/2001/tests/compiler/dart2js_nat...
tests/compiler/dart2js_native/apply_test.dart:21: List<String> namedArguments =
args.namedArguments.getKeys();
Are we assuming too much about what is returned from getKeys()? This code will
crash if it isn't a JS array, right?

https://codereview.chromium.org/10993036/diff/2001/tests/compiler/dart2js_nat...
tests/compiler/dart2js_native/apply_test.dart:35: return JS('var', '#.apply(#,
#)', jsFunction, function, arguments);
Add a comment that explains why you need 'this' to be bound to the function.

[ngeoffray, 2012-09-26 13:40:44]

Thanks Kasper.

https://codereview.chromium.org/10993036/diff/2001/tests/compiler/dart2js_nat...
File tests/compiler/dart2js_native/apply_test.dart (right):

https://codereview.chromium.org/10993036/diff/2001/tests/compiler/dart2js_nat...
tests/compiler/dart2js_native/apply_test.dart:9: int nbArguments = 0;
On 2012/09/26 13:23:43, kasperl wrote:
> nbArguments -> argumentCount?

Done.

https://codereview.chromium.org/10993036/diff/2001/tests/compiler/dart2js_nat...
tests/compiler/dart2js_native/apply_test.dart:19: // arguments order.
On 2012/09/26 13:23:43, kasperl wrote:
> Maybe add a comment that explains why you've decided on using JS sorting?

Done.

https://codereview.chromium.org/10993036/diff/2001/tests/compiler/dart2js_nat...
tests/compiler/dart2js_native/apply_test.dart:21: List<String> namedArguments =
args.namedArguments.getKeys();
On 2012/09/26 13:23:43, kasperl wrote:
> Are we assuming too much about what is returned from getKeys()? This code will
> crash if it isn't a JS array, right?

Yes, it will crash. I changed the code to do new List.from instead.

https://codereview.chromium.org/10993036/diff/2001/tests/compiler/dart2js_nat...
tests/compiler/dart2js_native/apply_test.dart:35: return JS('var', '#.apply(#,
#)', jsFunction, function, arguments);
On 2012/09/26 13:23:43, kasperl wrote:
> Add a comment that explains why you need 'this' to be bound to the function.

Done.

[ngeoffray, 2012-09-26 13:48:24]

+gilad, +lasse FYI