Issue 10993023: Inline String isEmpty, refactor inlining of intrinsics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10993023: Inline String isEmpty, refactor inlining of intrinsics. (Closed)

Created:
8 years, 2 months ago by srdjan

Modified:
8 years, 2 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Inline String isEmpty, refactor inlining of intrinsics. Committed: https://code.google.com/p/dart/source/detail?r=13032

Patch Set 5 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -70 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3 4	6 chunks	+130 lines, -70 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/string_intrinsics_test.dart	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://codereview.chromium.org/10993023/diff/5001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/10993023/diff/5001/runtime/vm/flow_graph_optimizer.cc#newcode724 runtime/vm/flow_graph_optimizer.cc:724: load->set_result_cid(kSmiCid); Maybe you can even share the code ...

8 years, 2 months ago (2012-09-26 08:36:12 UTC) #2

srdjan

8 years, 2 months ago (2012-09-28 16:56:56 UTC) #3

https://codereview.chromium.org/10993023/diff/5001/runtime/vm/flow_graph_opti...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/10993023/diff/5001/runtime/vm/flow_graph_opti...
runtime/vm/flow_graph_optimizer.cc:724: load->set_result_cid(kSmiCid);
On 2012/09/26 08:36:12, Florian Schneider wrote:
> Maybe you can even share the code for building the .length load between here
and
> InlineStringLengthGetter above using a helper BuildLoadStringLength.

Done.

Expand Messages | Collapse Messages

Issue 10993023: Inline String isEmpty, refactor inlining of intrinsics. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Messages