Reapply webkitRequestAimationFrame->requestAnimationFrame with fix for dartium

Reapply webkitRequestAimationFrame->requestAnimationFrame with fix for dartium
and IE.
Committed: https://code.google.com/p/dart/source/detail?r=12887

[Emily Fortuna, 2012-09-25 01:14:01]

https://codereview.chromium.org/10990013/diff/1/lib/html/templates/html/darti...
File lib/html/templates/html/dartium/impl_Window.darttemplate (left):

https://codereview.chromium.org/10990013/diff/1/lib/html/templates/html/darti...
lib/html/templates/html/dartium/impl_Window.darttemplate:11: int
requestAnimationFrame(RequestAnimationFrameCallback callback) =>
I had accidentally left off this file from the previous CL, which caused the
error in Dartium.

https://codereview.chromium.org/10990013/diff/2001/lib/html/templates/html/da...
File lib/html/templates/html/dartium/impl_Window.darttemplate (left):

https://codereview.chromium.org/10990013/diff/2001/lib/html/templates/html/da...
lib/html/templates/html/dartium/impl_Window.darttemplate:12:
webkitRequestAnimationFrame(callback);
I had accidentally left off this file from the previous CL, which caused the
error in Dartium.

https://codereview.chromium.org/10990013/diff/2001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/10990013/diff/2001/tests/html/html.status#new...
tests/html/html.status:97: serialized_script_value_test: Fail
callbacks_test fails in IE, which also uses requestAnimationFrame. It's unclear
to me why this was appearing to pass in IE to begin with. @sra, you wrote the
test -- do you have any insight why this was even passing before? Now it's
throwing a NSME, like callbacks_test, which is what I'd expect...

[blois, 2012-09-25 17:52:28]

https://codereview.chromium.org/10990013/diff/2001/lib/html/templates/html/da...
File lib/html/templates/html/dart2js/impl_Window.darttemplate (right):

https://codereview.chromium.org/10990013/diff/2001/lib/html/templates/html/da...
lib/html/templates/html/dart2js/impl_Window.darttemplate:94: native
'webkitRequestAnimationFrame';
This should be requestAnimationFrame.

https://codereview.chromium.org/10990013/diff/2001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/10990013/diff/2001/tests/html/html.status#new...
tests/html/html.status:97: serialized_script_value_test: Fail
On 2012/09/25 01:14:01, Emily Fortuna wrote:
> callbacks_test fails in IE, which also uses requestAnimationFrame. It's
unclear
> to me why this was appearing to pass in IE to begin with. @sra, you wrote the
> test -- do you have any insight why this was even passing before? Now it's
> throwing a NSME, like callbacks_test, which is what I'd expect...

This is failing because the implementation is now calling
webkitRequestAnimationFrame rather than requestAnimationFrame (see my comment
there).

This test should be passing, as well as callbacks_test.

Note that callbacks_test will timeout on drt since RAF doesn't callback there.

[Emily Fortuna, 2012-09-25 23:03:27]

ah, ha. Sorry I didn't catch that before. Now it should be ready. PTAL.

[blois, 2012-09-25 23:19:04]

On 2012/09/25 23:03:27, Emily Fortuna wrote:
> ah, ha. Sorry I didn't catch that before. Now it should be ready. PTAL.

[blois, 2012-09-25 23:19:15]

https://codereview.chromium.org/10990013/diff/10/lib/html/dart2js/html_dart2j...
File lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/10990013/diff/10/lib/html/dart2js/html_dart2j...
lib/html/dart2js/html_dart2js.dart:37924: +  void cancelAnimationFrame(int id);
I believe that cancelAnimationFrame is the old syntax, replaced by the W3C with
cancelRequestAnimationFrame. Seems like we should only expose one.

https://codereview.chromium.org/10990013/diff/10/tests/html/callbacks_test.dart
File tests/html/callbacks_test.dart (right):

https://codereview.chromium.org/10990013/diff/10/tests/html/callbacks_test.da...
tests/html/callbacks_test.dart:9: window.requestAnimationFrame((int time) =>
false);
This should cause this test to be passing on IE and FF, doesn't the status file
need updating?

[Emily Fortuna, 2012-09-26 00:45:27]

@Pete. Good point I was not aware that one was going to be dropped.
Fixed up and even tested on Windows. Should be ready this time.
PTAL.

[blois, 2012-09-26 00:48:25]

lgtm