Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 109893005: Change polymer tests to use internal test_controller, not unittest/test_controller. (Closed)

Created:
7 years ago by Bill Hesse
Modified:
7 years ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change polymer tests to use internal test_controller, not unittest/test_controller. BUG= R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=31021

Patch Set 1 #

Patch Set 2 : Remove dead _isJSSeen variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -29 lines) Patch
M pkg/polymer/example/canonicalization/test/canonicalization_deploy_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization/test/canonicalization_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/component/news/test/news_index_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/build/linter.dart View 1 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/polymer/test/attr_deserialize_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/attr_mustache_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/bind_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/custom_event_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/event_handlers_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/event_path_declarative_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/event_path_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/events_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/instance_attrs_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/nested_binding_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/noscript_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/prop_attr_bind_reflection_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/prop_attr_reflection_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/property_change_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/publish_attributes_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/publish_inherited_properties_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/register_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/take_attributes_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/template_distribute_dynamic_test.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/unbind_test.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
Checked with multiple compilers and browsers on Linux, checking on Windows. Verified that an injected ...
7 years ago (2013-12-10 12:27:39 UTC) #1
kustermann
LGTM
7 years ago (2013-12-10 12:55:44 UTC) #2
Bill Hesse
7 years ago (2013-12-10 15:34:16 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r31021 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698