Attempt to deflake our status files

Attempt to deflake our status files

R=whesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31022

[kustermann, 2013-12-10 14:33:53]

This is based on a (semi)automated tool which goes through all test results of
all builders (except dartium) and looks if tests were really flaky or if they
are consistently passing/failing.

This is the first attempt.

[Bill Hesse, 2013-12-10 14:59:15]

This LGTM.  Maybe we could skip changing the polymer files in this run, since I
will be changing them soon.

I'm sure some of these changes will need reverted, since the tool isn't perfect,
but we will find out from the buildbot.

https://codereview.chromium.org/109893004/diff/20001/dart/pkg/pkg.status
File dart/pkg/pkg.status (left):

https://codereview.chromium.org/109893004/diff/20001/dart/pkg/pkg.status#oldc...
dart/pkg/pkg.status:274: barback/test/too_many_open_files_test: Pass, Slow, Fail
# 14220
How does the tool know whether to remove "Slow"?  I would leave it in.

https://codereview.chromium.org/109893004/diff/20001/dart/tests/co19/co19-dar...
File dart/tests/co19/co19-dart2js.status (left):

https://codereview.chromium.org/109893004/diff/20001/dart/tests/co19/co19-dar...
dart/tests/co19/co19-dart2js.status:256:
LibTest/async/Future/catchError_A03_t05: Pass, RuntimeError # Issue 14712
Will we edit all the bugs whose entries in the status file we change?  Waiting
first to see if the status change is ok?

https://codereview.chromium.org/109893004/diff/20001/dart/tests/co19/co19-dar...
File dart/tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/109893004/diff/20001/dart/tests/co19/co19-dar...
dart/tests/co19/co19-dart2js.status:69: LibTest/isolate/SendPort/send_A02_t05:
RuntimeError # TODO(ahe): Please triage this failure.
We should handle the TODO at this point.

[kustermann, 2013-12-10 15:37:51]

Committed patchset #2 manually as r31022 (presubmit successful).

[kustermann, 2013-12-10 15:58:20]

https://codereview.chromium.org/109893004/diff/20001/dart/pkg/pkg.status
File dart/pkg/pkg.status (left):

https://codereview.chromium.org/109893004/diff/20001/dart/pkg/pkg.status#oldc...
dart/pkg/pkg.status:274: barback/test/too_many_open_files_test: Pass, Slow, Fail
# 14220
On 2013/12/10 14:59:16, Bill Hesse wrote:
> How does the tool know whether to remove "Slow"?  I would leave it in.

That was my fault (the tool writes out something else, and I incorporate the
changes into the status file).

https://codereview.chromium.org/109893004/diff/20001/dart/tests/co19/co19-dar...
File dart/tests/co19/co19-dart2js.status (left):

https://codereview.chromium.org/109893004/diff/20001/dart/tests/co19/co19-dar...
dart/tests/co19/co19-dart2js.status:256:
LibTest/async/Future/catchError_A03_t05: Pass, RuntimeError # Issue 14712
On 2013/12/10 14:59:16, Bill Hesse wrote:
> Will we edit all the bugs whose entries in the status file we change?  Waiting
> first to see if the status change is ok?

We could do that, but I think we will do that anyway at some points for *ALL*
bugs mentioned in status files (there are tons of bugs that have been closed,
but status files still refer to them ...).

https://codereview.chromium.org/109893004/diff/20001/dart/tests/co19/co19-dar...
File dart/tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/109893004/diff/20001/dart/tests/co19/co19-dar...
dart/tests/co19/co19-dart2js.status:69: LibTest/isolate/SendPort/send_A02_t05:
RuntimeError # TODO(ahe): Please triage this failure.
On 2013/12/10 14:59:16, Bill Hesse wrote:
> We should handle the TODO at this point.

I don't think we should. If we have a test and dart2js fails that test, it's up
to the dart2js team to triage the issue (and possibly fix it).