Issue 10989074: Handle receiving GrowableObjectArrays correctly on native ports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10989074: Handle receiving GrowableObjectArrays correctly on native ports (Closed)

Created:
8 years, 2 months ago by Søren Gjesse

Modified:
8 years, 2 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle receiving GrowableObjectArrays correctly on native ports The deserialization when receiving GrowableObjectArrays through native ports was not correct. A GrowableObjectArrays is now handled as an internal VM object and is now handled on all code paths. Added a more comprehensiive test using array literals which are represented as GrowableObjectArrays. R=ager@google.com BUG=dart:5474 Committed: https://code.google.com/p/dart/source/detail?r=12992

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -25 lines)			Patch
	M	runtime/vm/dart_api_message.cc	View		3 chunks	+23 lines, -18 lines	0 comments	Download
	M	runtime/vm/snapshot_test.cc	View		3 chunks	+114 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages