Issue 10989022: Temporarily expose createObjectUrl/revokeObjectUrl on window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10989022: Temporarily expose createObjectUrl/revokeObjectUrl on window. (Closed)

Created:
8 years, 2 months ago by Anton Muhin

Modified:
8 years, 2 months ago

Reviewers:
podivilov, sra1, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Temporarily expose createObjectUrl/revokeObjectUrl on window. TBR=blois@google.com,podivilov@chromium.org,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=12871

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -4 lines)			Patch
M	lib/html/templates/html/dartium/impl_Window.darttemplate	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/html/url_test.dart	View	2 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

8 years, 2 months ago (2012-09-25 19:45:04 UTC) #2

FYI- I reverted this change as it broke dart2js builds (the issue I mentioned in
the test).

Since this is a blocking issue I'll be following up with a new CL with the fix.

https://codereview.chromium.org/10989022/diff/1/tests/html/url_test.dart
File tests/html/url_test.dart (left):

https://codereview.chromium.org/10989022/diff/1/tests/html/url_test.dart#oldc...
tests/html/url_test.dart:59: DOMURL.revokeObjectURL(url);
FYI- this API needs to change to window.revokeObjectUrl.

Expand Messages | Collapse Messages