Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 10989017: Fix invalid locations problem for inline super constructors. (Closed)

Created:
8 years, 2 months ago by podivilov
Modified:
8 years, 2 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix invalid locations problem for inline super constructors. This is a quick fix for issue 5184. R=ahe@google.com BUG=5184 Committed: https://code.google.com/p/dart/source/detail?r=12853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M lib/compiler/implementation/ssa/builder.dart View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
podivilov
Currently compiler could possibly crash only when elements belong to different source files. More robust ...
8 years, 2 months ago (2012-09-25 14:30:46 UTC) #1
ahe
LGTM, but I would really like to have a test case for this. See the ...
8 years, 2 months ago (2012-09-25 15:22:30 UTC) #2
podivilov
8 years, 2 months ago (2012-09-25 17:16:56 UTC) #3
On 2012/09/25 15:22:30, ahe wrote:
> LGTM, but I would really like to have a test case for this.
> 
> See the test I wrote for http://code.google.com/p/dart/source/detail?r=12787.
> 
> Notice how I use a long comment to force a crash.

Landing this as is to resolve P1 issue. I'm going to add a test tomorrow.

Powered by Google App Engine
This is Rietveld 408576698