Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 10989016: Add is_inlinable field to functions. (Closed)

Created:
8 years, 2 months ago by zerny-google
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add is_inlinable field to functions. Repeated attempts at inlining functions that cannot be inlined leads to noticeable performance regression when compiling with dart2js. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=12842

Patch Set 1 #

Patch Set 2 : Use bit field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zerny-google
8 years, 2 months ago (2012-09-25 11:48:59 UTC) #1
zerny-google
Now using a bit in kind_tag_ bits.
8 years, 2 months ago (2012-09-25 12:48:02 UTC) #2
Vyacheslav Egorov (Google)
8 years, 2 months ago (2012-09-25 12:49:25 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698