Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 109883003: Remove wrong assertion, and make sure we only change the type of constant lists. (Closed)

Created:
7 years ago by ngeoffray
Modified:
7 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove wrong assertion, and make sure we only change the type of constant lists. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=31279

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/nodes.dart View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ngeoffray
I added this assertion while implementing: https://codereview.chromium.org/114613003/, to ensure we don't get weird types for ...
7 years ago (2013-12-19 16:10:46 UTC) #1
ngeoffray
I added this assertion while implementing: https://codereview.chromium.org/114613003/, to ensure we don't get weird types for ...
7 years ago (2013-12-19 16:10:46 UTC) #2
floitsch
LGTM with comments. https://codereview.chromium.org/109883003/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (right): https://codereview.chromium.org/109883003/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart#newcode1936 sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:1936: // Only lists can be specialized. ...
7 years ago (2013-12-19 16:16:29 UTC) #3
ngeoffray
Thanks Florian. https://codereview.chromium.org/109883003/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (right): https://codereview.chromium.org/109883003/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart#newcode1936 sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:1936: // Only lists can be specialized. On ...
7 years ago (2013-12-19 16:17:51 UTC) #4
ngeoffray
7 years ago (2013-12-19 16:18:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r31279 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698