Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1098793002: pkg/test: calculate the SDK dir in one place (Closed)

Created:
5 years, 8 months ago by kevmoo
Modified:
5 years, 8 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/test.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/src/util/io.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
kevmoo
5 years, 8 months ago (2015-04-18 16:18:52 UTC) #2
nweiz
lgtm
5 years, 8 months ago (2015-04-20 18:18:52 UTC) #3
kevmoo
5 years, 8 months ago (2015-04-20 18:32:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dbbdbd01c669faaf3ebb7108499dc326aea74e49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698