Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 10987080: Adding 'supported' check for shadow root. (Closed)

Created:
8 years, 2 months ago by blois
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding 'supported' check for shadow root. This fixes the case for JS, but still throws for Dartium, I'll pass this onto Anton to fix the Dartium case to not throw. BUG=5537 Committed: https://code.google.com/p/dart/source/detail?r=12986

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporating review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -7 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 3 chunks +11 lines, -1 line 0 comments Download
M lib/html/dartium/html_dartium.dart View 3 chunks +12 lines, -1 line 0 comments Download
M lib/html/templates/html/dart2js/factoryprovider_ShadowRoot.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
A lib/html/templates/html/impl/impl_ShadowRoot.darttemplate View 1 1 chunk +23 lines, -0 lines 0 comments Download
A + lib/html/templates/html/interface/interface_ShadowRoot.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/shadow_dom_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A tests/html/shadowroot_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
blois
8 years, 2 months ago (2012-09-27 21:13:32 UTC) #1
Jennifer Messerly
Probably want to change lib/html/templates/html/dart2js/factoryprovider_ShadowRoot.darttemplate too? The current create method only checks for the WebKit ...
8 years, 2 months ago (2012-09-27 21:18:47 UTC) #2
Jennifer Messerly
For what it's worth, this lgtm modulo previous comments :)
8 years, 2 months ago (2012-09-27 21:19:38 UTC) #3
blois
https://codereview.chromium.org/10987080/diff/1/lib/html/templates/html/impl/impl_ShadowRoot.darttemplate File lib/html/templates/html/impl/impl_ShadowRoot.darttemplate (right): https://codereview.chromium.org/10987080/diff/1/lib/html/templates/html/impl/impl_ShadowRoot.darttemplate#newcode11 lib/html/templates/html/impl/impl_ShadowRoot.darttemplate:11: JS('bool', '!!(window.WebKitShadowRoot || window.ShadowRoot)'); On 2012/09/27 21:18:47, John Messerly ...
8 years, 2 months ago (2012-09-27 21:36:31 UTC) #4
Jennifer Messerly
lgtm, thank you!
8 years, 2 months ago (2012-09-27 22:54:23 UTC) #5
Anton Muhin
Pete, fill free to reassign the bug to me.
8 years, 2 months ago (2012-09-28 10:49:54 UTC) #6
vsm
8 years, 2 months ago (2012-09-28 15:08:46 UTC) #7
lgtm.

Is the convention we want to support elsewhere?

Powered by Google App Engine
This is Rietveld 408576698