Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 10987045: add Element.xtag to public interface (Closed)

Created:
8 years, 2 months ago by Jennifer Messerly
Modified:
8 years, 2 months ago
Reviewers:
vsm, Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add Element.xtag to public interface This lets us refer to it easily, instead of via (element as Dynamic).xtag, which in turn allows users to think about it as the Element being the source of truth, and storing a reference to the Element instead of the WebComponent object. I opened up the doc comment in Firefox to double check that it renders correctly in API doc. Committed: https://code.google.com/p/dart/source/detail?r=12917

Patch Set 1 #

Patch Set 2 : generate bindings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_Element.darttemplate View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jennifer Messerly
8 years, 2 months ago (2012-09-26 02:25:04 UTC) #1
vsm
8 years, 2 months ago (2012-09-26 02:54:42 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698