Refactor file paths handling in generator.

Refactor file paths handling in generator.

Introduce DartLibraryGenerator and CPPLibraryGenerator classes
that are responsible for creating per-interface files and importing
them into single library file at the end.

System and BaseGenerator implementations don't have to deal with file paths anymore.

R=antonm@google.com,vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=12898

[vsm, 2012-09-25 16:06:14]

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartdomgener...
File lib/html/scripts/dartdomgenerator.py (right):

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartdomgener...
lib/html/scripts/dartdomgenerator.py:72: def Generate(dart_library_template,
dart_output_dir, dart_library_path,
Can you use a different name here?  It shadows the top-level Generate.

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartdomgener...
lib/html/scripts/dartdomgenerator.py:75: ['html/interface', 'html/impl', 'html',
''],
nit: line length

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartgenerato...
File lib/html/scripts/dartgenerator.py (right):

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartgenerato...
lib/html/scripts/dartgenerator.py:191: def Generate(self, database,
super_database, webkit_renames,
Should this be renamed to Process or similar?  It looks like it's no longer
generating code.

[Anton Muhin, 2012-09-25 16:15:50]

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartgenerato...
File lib/html/scripts/dartgenerator.py (right):

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartgenerato...
lib/html/scripts/dartgenerator.py:192: process_interface, process_callback):
why pass callbacks, not some generator?

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/systemhtml.py
File lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/systemhtml.p...
lib/html/scripts/systemhtml.py:1250: def MassagePath(self, path):
turn MassagePath into closure if it's not used outside of this class?  Or maybe
just inline it

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/systemnative.py
File lib/html/scripts/systemnative.py (right):

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/systemnative...
lib/html/scripts/systemnative.py:865: class CPPLibraryGenerator():
nit: Should we capitalize CPP?  That looks somewhat weird to me, but I am not
insisting

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/systemnative...
lib/html/scripts/systemnative.py:873: path = os.path.join(self._cpp_sources_dir,
'Dart%s.h' % interface_name)
looks like common code (see CreateSourceEmitter), care to factor out into a
helper method?

[podivilov1, 2012-09-25 16:40:28]

PTAL.

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartdomgener...
File lib/html/scripts/dartdomgenerator.py (right):

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartdomgener...
lib/html/scripts/dartdomgenerator.py:72: def Generate(dart_library_template,
dart_output_dir, dart_library_path,
On 2012/09/25 16:06:14, vsm wrote:
> Can you use a different name here?  It shadows the top-level Generate.

Done.

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartdomgener...
lib/html/scripts/dartdomgenerator.py:75: ['html/interface', 'html/impl', 'html',
''],
On 2012/09/25 16:06:14, vsm wrote:
> nit: line length

Done.

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartgenerato...
File lib/html/scripts/dartgenerator.py (right):

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartgenerato...
lib/html/scripts/dartgenerator.py:191: def Generate(self, database,
super_database, webkit_renames,
On 2012/09/25 16:06:14, vsm wrote:
> Should this be renamed to Process or similar?  It looks like it's no longer
> generating code.

Reverted this change. I'll try to decouple dartgenerator from System in a
separate change.

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/dartgenerato...
lib/html/scripts/dartgenerator.py:192: process_interface, process_callback):
On 2012/09/25 16:15:50, Anton Muhin wrote:
> why pass callbacks, not some generator? 

Done.

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/systemhtml.py
File lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/systemhtml.p...
lib/html/scripts/systemhtml.py:1250: def MassagePath(self, path):
On 2012/09/25 16:15:50, Anton Muhin wrote:
> turn MassagePath into closure if it's not used outside of this class?  Or
maybe
> just inline it

Done.

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/systemnative.py
File lib/html/scripts/systemnative.py (right):

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/systemnative...
lib/html/scripts/systemnative.py:865: class CPPLibraryGenerator():
On 2012/09/25 16:15:50, Anton Muhin wrote:
> nit: Should we capitalize CPP?  That looks somewhat weird to me, but I am not
> insisting

There's _GenerateCPPIncludes function below, and git grep CPP WebKit/Source
shows that it's preferred style in WebKit as well.

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/systemnative...
lib/html/scripts/systemnative.py:873: path = os.path.join(self._cpp_sources_dir,
'Dart%s.h' % interface_name)
On 2012/09/25 16:15:50, Anton Muhin wrote:
> looks like common code (see CreateSourceEmitter), care to factor out into a
> helper method?

Additional logic for callback headers makes me think it not worth doing.

[Anton Muhin, 2012-09-25 16:50:26]

lgtm

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/systemnative.py
File lib/html/scripts/systemnative.py (right):

https://codereview.chromium.org/10987019/diff/1/lib/html/scripts/systemnative...
lib/html/scripts/systemnative.py:865: class CPPLibraryGenerator():
Under lib/html/scripts preferred style is apparently Cpp vs CPP.

Again, that was a nit.

On 2012/09/25 16:40:28, podivilov1 wrote:
> On 2012/09/25 16:15:50, Anton Muhin wrote:
> > nit: Should we capitalize CPP?  That looks somewhat weird to me, but I am
not
> > insisting
> 
> There's _GenerateCPPIncludes function below, and git grep CPP WebKit/Source
> shows that it's preferred style in WebKit as well.

[vsm, 2012-09-25 17:27:45]

lgtm, but i'm still finding the overuse of "Generate" confusing.  A suggestion
below.

https://codereview.chromium.org/10987019/diff/7001/lib/html/scripts/dartdomge...
File lib/html/scripts/dartdomgenerator.py (right):

https://codereview.chromium.org/10987019/diff/7001/lib/html/scripts/dartdomge...
lib/html/scripts/dartdomgenerator.py:83:
dart_library_generator.GenerateLibrary(dart_library_path, auxiliary_dir)
It's confusing to use "Generate" on both of these steps (i.e., "Generate" and
"GenerateLibrary".  My understanding is that the first is generating code and
the second is emitting.  If so, how about renaming to
DartLibraryEmitter.EmitLibrary?

[podivilov1, 2012-09-26 09:54:06]

https://codereview.chromium.org/10987019/diff/7001/lib/html/scripts/dartdomge...
File lib/html/scripts/dartdomgenerator.py (right):

https://codereview.chromium.org/10987019/diff/7001/lib/html/scripts/dartdomge...
lib/html/scripts/dartdomgenerator.py:83:
dart_library_generator.GenerateLibrary(dart_library_path, auxiliary_dir)
On 2012/09/25 17:27:45, vsm wrote:
> It's confusing to use "Generate" on both of these steps (i.e., "Generate" and
> "GenerateLibrary".  My understanding is that the first is generating code and
> the second is emitting.  If so, how about renaming to
> DartLibraryEmitter.EmitLibrary?  

Done.