Issue 10986078: Adding more relative path support.

Issue 10986078: Adding more relative path support. (Closed)

Created:
8 years, 2 months ago by blois

Modified:
8 years, 2 months ago

Reviewers:
Bill Hesse, Mads Ager (google), ahe

CC:
reviews_dartlang.org, Lasse Reichstein

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Improving relative path support. I'm looking to modify our HTML tests to use relative paths and it was mentioned that I should be using Path.relativeTo- this change fixes relativeTo to handle the cases that I need. BUG= Committed: https://code.google.com/p/dart/source/detail?r=13422

Patch Set 1 #

Patch Set 2 : Cleanup tests and fixes based on tests. #

Total comments: 2

Patch Set 3 : Incorporating review feedback (removing debugging output). #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -2 lines)			Patch
	M	runtime/bin/path_impl.dart	View	1 2	1 chunk	+25 lines, -1 line	0 comments	Download
	M	tests/standalone/io/path_test.dart	View	1	3 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vsm

Ping: Any chance you guys can take a look at this soon? Pete's relative path ...

8 years, 2 months ago (2012-10-08 18:55:35 UTC) #2

Mads Ager (google)

LGTM! https://codereview.chromium.org/10986078/diff/2001/runtime/bin/path_impl.dart File runtime/bin/path_impl.dart (right): https://codereview.chromium.org/10986078/diff/2001/runtime/bin/path_impl.dart#newcode60 runtime/bin/path_impl.dart:60: print('common $common blLength: ${baseSegments.length}'); Please remove debug printing.

8 years, 2 months ago (2012-10-09 07:02:57 UTC) #4

blois

8 years, 2 months ago (2012-10-09 16:47:13 UTC) #5

https://codereview.chromium.org/10986078/diff/2001/runtime/bin/path_impl.dart
File runtime/bin/path_impl.dart (right):

https://codereview.chromium.org/10986078/diff/2001/runtime/bin/path_impl.dart...
runtime/bin/path_impl.dart:60: print('common $common blLength:
${baseSegments.length}');
On 2012/10/09 07:02:57, Mads Ager wrote:
> Please remove debug printing.

d'oh! Done.

Expand Messages | Collapse Messages