Issue 10985089: Fix the type on a wrapped window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10985089: Fix the type on a wrapped window (Closed)

Created:
8 years, 2 months ago by vsm

Modified:
8 years, 2 months ago

Reviewers:
sra, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix the type on a wrapped window Committed: https://code.google.com/p/dart/source/detail?r=13141

Patch Set 3 : Regen dart:html #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/html/src/dart2js_DOMImplementation.dart	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tests/html/html.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

https://codereview.chromium.org/10985089/diff/1/lib/html/src/dart2js_DOMImplementation.dart File lib/html/src/dart2js_DOMImplementation.dart (right): https://codereview.chromium.org/10985089/diff/1/lib/html/src/dart2js_DOMImplementation.dart#newcode8 lib/html/src/dart2js_DOMImplementation.dart:8: var _window; This is a window to another frame. ...

8 years, 2 months ago (2012-09-28 21:02:42 UTC) #1

sra1

8 years, 2 months ago (2012-10-02 21:14:47 UTC) #2

lgtm

LGTM with comments

https://chromiumcodereview.appspot.com/10985089/diff/1/lib/html/src/dart2js_D...
File lib/html/src/dart2js_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/10985089/diff/1/lib/html/src/dart2js_D...
lib/html/src/dart2js_DOMImplementation.dart:8: var _window;
On 2012/09/28 21:02:42, vsm wrote:
> This is a window to another frame.  It's proto is not patched accordingly, so
> dart2js doesn't recognize this as a _WindowImpl.  It was previously causing
> checked mode failures.

Say this in a comment.
"Declared var since Window from another frame has no Dart type."

Expand Messages | Collapse Messages

Issue 10985089: Fix the type on a wrapped window (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add comment #

Patch Set 3 : Regen dart:html #

Messages