Issue 10985005: Implement part directive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10985005: Implement part directive (Closed)

Created:
8 years, 3 months ago by hausner

Modified:
8 years, 3 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement part directive This replaces the existing #source directive. Committed: https://code.google.com/p/dart/source/detail?r=12818

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
M	runtime/vm/parser.cc	View	1 2	1 chunk	+12 lines, -1 line	0 comments	Download
A	tests/language/import_combinators_part.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	tests/language/import_combinators_test.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/10985005/diff/2001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): http://codereview.chromium.org/10985005/diff/2001/runtime/vm/parser.cc#newcode4275 runtime/vm/parser.cc:4275: ConsumeToken(); What token are you consuming? ASSERT(CurrentToken() == ...

8 years, 3 months ago (2012-09-24 23:10:27 UTC) #2

hausner

8 years, 3 months ago (2012-09-24 23:18:35 UTC) #3

Thank you.

http://codereview.chromium.org/10985005/diff/2001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10985005/diff/2001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:4275: ConsumeToken();
I added a comment instead of an assert. I think we have too many asserts that
collectively bloat the debug build.

On 2012/09/24 23:10:27, regis wrote:
> What token are you consuming?
> ASSERT(CurrentToken() == ...)?

Expand Messages | Collapse Messages

Issue 10985005: Implement part directive (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages