Issue 10984055: Replacing non-portable CanvasRenderingContext.setFillColor with more portable variants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10984055: Replacing non-portable CanvasRenderingContext.setFillColor with more portable variants. (Closed)

Created:
8 years, 2 months ago by blois

Modified:
8 years, 2 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Replacing non-portable CanvasRenderingContext.setFillColor with more portable variants. Original CL failed because: Additional tests were marked as fail because they used the broken behavior. I've fixed these tests and removed their exclusions. Argument types were mismatched, causing Dartium to fail. BUG=4592 Committed: https://code.google.com/p/dart/source/detail?r=12972

Patch Set 1 #

Patch Set 2 : Fixing tests and running on dartium. #

Patch Set 3 : Syncing to latest. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+242 lines, -133 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		6 chunks	+49 lines, -10 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		7 chunks	+46 lines, -89 lines	0 comments	Download
M	lib/html/scripts/htmlrenamer.py	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
A	lib/html/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
A	lib/html/templates/html/interface/interface_CanvasRenderingContext2D.darttemplate	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
M	tests/html/canvas_test.dart	View	1	1 chunk	+0 lines, -15 lines	0 comments	Download
M	tests/html/canvas_using_html_test.dart	View	1	1 chunk	+0 lines, -15 lines	0 comments	Download
A	tests/html/canvasrenderingcontext2d_test.dart	View		1 chunk	+84 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages