Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10984051: More compact code for strict compare with 0. (Closed)

Created:
8 years, 2 months ago by srdjan
Modified:
8 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

More compact code for strict compare with 0. Noticed while tracking mysterious Bubblesort performance degradation. Committed: https://code.google.com/p/dart/source/detail?r=12929

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -4 lines) Patch
M runtime/vm/flow_graph_compiler_ia32.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language/strict_equal_test.dart View 2 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
8 years, 2 months ago (2012-09-26 20:36:34 UTC) #1
regis
8 years, 2 months ago (2012-09-26 20:55:48 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698