Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 10983052: Revert "Replacing non-portable CanvasRenderingContext.setFillColor with more portable variants." (Closed)

Created:
8 years, 2 months ago by blois
Modified:
8 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Replacing non-portable CanvasRenderingContext.setFillColor with more portable variants." This reverts commit 10979029. This broke dartium (not sure why) and canvas_test, which actually relied on the broken behavior. TBR=vsm BUG= Committed: https://code.google.com/p/dart/source/detail?r=12936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -241 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 6 chunks +10 lines, -49 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 6 chunks +88 lines, -45 lines 0 comments Download
M lib/html/scripts/htmlrenamer.py View 1 chunk +0 lines, -2 lines 0 comments Download
D lib/html/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 1 chunk +0 lines, -23 lines 0 comments Download
D lib/html/templates/html/interface/interface_CanvasRenderingContext2D.darttemplate View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/html/canvasrenderingcontext2d_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
blois
8 years, 2 months ago (2012-09-26 22:59:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698