Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 10982070: Attempt to fix dartium mac build (Closed)

Created:
8 years, 2 months ago by ahe
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Attempt to fix dartium mac build Committed: https://code.google.com/p/dart/source/detail?r=12969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M dart/runtime/tools/gyp/runtime-configurations.gypi View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
This is a hunch.
8 years, 2 months ago (2012-09-27 15:27:57 UTC) #1
ricow1
LGTM, lets give it a shot
8 years, 2 months ago (2012-09-27 15:29:50 UTC) #2
ahe
Let me try to explain what I think is going on: Because dart/runtime/tools/gyp/runtime-configurations.gypi is included ...
8 years, 2 months ago (2012-09-27 15:57:14 UTC) #3
Anton Muhin
Thanks a lot, Peter. Just for my education, where I can find any info about ...
8 years, 2 months ago (2012-09-28 09:58:09 UTC) #4
ahe
8 years, 2 months ago (2012-09-28 10:41:58 UTC) #5
On 2012/09/28 09:58:09, Anton Muhin wrote:
> Just for my education, where I can find any info about abstract vs. concrete
> configurations?

I'm not sure. All I know I have guessed or deducted from the sources.

Powered by Google App Engine
This is Rietveld 408576698