Make data setter private on GrowableObjectArray.

Make data setter private on GrowableObjectArray.

There is no data setter on Lists. Additionally, this allows to
create buffer overflows.

R=vegorov@google.com,iposva@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=12941

[srdjan, 2012-09-26 15:33:00]

DBC

https://codereview.chromium.org/10982045/diff/1/runtime/lib/growable_array.dart
File runtime/lib/growable_array.dart (right):

https://codereview.chromium.org/10982045/diff/1/runtime/lib/growable_array.da...
runtime/lib/growable_array.dart:111: void _setData(ObjectArray<T> array) native
"GrowableObjectArray_setData";
Please adapt intrinsifier.h (s/set:data/_setData/)

[Mads Ager (google), 2012-09-26 16:08:31]

https://codereview.chromium.org/10982045/diff/1/runtime/lib/growable_array.dart
File runtime/lib/growable_array.dart (right):

https://codereview.chromium.org/10982045/diff/1/runtime/lib/growable_array.da...
runtime/lib/growable_array.dart:111: void _setData(ObjectArray<T> array) native
"GrowableObjectArray_setData";
On 2012/09/26 15:33:00, srdjan wrote:
> Please adapt intrinsifier.h (s/set:data/_setData/)

Thanks Srdjan! Done!

(That was actually how I noticed this. I was updating the intrinsifier for a
different change when I stumbled upon this. And then I forgot to update the
intrinsifier in this change. Go figure. ;-)

[Ivan Posva, 2012-09-26 17:16:16]

LGTM -ip