Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 10981070: Second attempt to fix issue 3402. It turns out that we can't use (Closed)

Created:
8 years, 2 months ago by dgrove
Modified:
8 years, 2 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Second attempt to fix issue 3402. It turns out that we can't use $_, because that contains the original script name (in the case test.py, $_ contains .../test.py when this script is executed. Using $0 will work fine, as pwd -P will give the absolute physical path of the dart script. Committed: https://code.google.com/p/dart/source/detail?r=13030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M utils/compiler/build_helper.dart View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dgrove
8 years, 2 months ago (2012-09-28 17:12:48 UTC) #1
ahe
8 years, 2 months ago (2012-09-28 17:17:11 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698