dartdoc supports isAbstract on methods

dartdoc supports isAbstract on methods

isAbstract added to InterfaceMirror and MethodMirror and used in dartdoc. 
InterfaceMirror.isAbstract is currently not support by dart2js since modifiers are not stored for ClassElement.


BUG=2926
Committed: https://code.google.com/p/dart/source/detail?r=13017

[Lasse Reichstein Nielsen, 2012-09-28 08:33:37]

LGTM

https://codereview.chromium.org/10981058/diff/1/pkg/dartdoc/lib/mirrors.dart
File pkg/dartdoc/lib/mirrors.dart (right):

https://codereview.chromium.org/10981058/diff/1/pkg/dartdoc/lib/mirrors.dart#...
pkg/dartdoc/lib/mirrors.dart:204: * Is [:true:] if this class is abstract.
"is abstract" -> "is declared abstract".
It's the same thing (being declared abstract is the only way to become
abstract), but makes it more explicit that someone declared the class abstract.

https://codereview.chromium.org/10981058/diff/1/pkg/dartdoc/lib/mirrors.dart#...
pkg/dartdoc/lib/mirrors.dart:358: * Is the reflectee abstract?
Doesn't follow the same structure(s?) as the other getters.
Use "Is [:true:] if ..." as below.
Or, if you prefer a shorter version, don't make it a question:
 * Whether this method is abstract.

https://codereview.chromium.org/10981058/diff/1/pkg/dartdoc/lib/src/mirrors/d...
File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right):

https://codereview.chromium.org/10981058/diff/1/pkg/dartdoc/lib/src/mirrors/d...
pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:1326: _function.modifiers !==
null && _function.modifiers.isAbstract();
Could we have a default const modifiers object (a null object) that is stored
instead of null ... so we don't have to test for null every bloody time we use
modifiers?

[Johnni Winther, 2012-09-28 13:08:06]

https://codereview.chromium.org/10981058/diff/1/pkg/dartdoc/lib/mirrors.dart
File pkg/dartdoc/lib/mirrors.dart (right):

https://codereview.chromium.org/10981058/diff/1/pkg/dartdoc/lib/mirrors.dart#...
pkg/dartdoc/lib/mirrors.dart:204: * Is [:true:] if this class is abstract.
On 2012/09/28 08:33:37, Lasse Reichstein Nielsen wrote:
> "is abstract" -> "is declared abstract".
> It's the same thing (being declared abstract is the only way to become
> abstract), but makes it more explicit that someone declared the class
abstract.

Done.

https://codereview.chromium.org/10981058/diff/1/pkg/dartdoc/lib/mirrors.dart#...
pkg/dartdoc/lib/mirrors.dart:358: * Is the reflectee abstract?
On 2012/09/28 08:33:37, Lasse Reichstein Nielsen wrote:
> Doesn't follow the same structure(s?) as the other getters.
> Use "Is [:true:] if ..." as below.
> Or, if you prefer a shorter version, don't make it a question:
>  * Whether this method is abstract. 

Done.

https://codereview.chromium.org/10981058/diff/1/pkg/dartdoc/lib/src/mirrors/d...
File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right):

https://codereview.chromium.org/10981058/diff/1/pkg/dartdoc/lib/src/mirrors/d...
pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:1326: _function.modifiers !==
null && _function.modifiers.isAbstract();
On 2012/09/28 08:33:37, Lasse Reichstein Nielsen wrote:
> Could we have a default const modifiers object (a null object) that is stored
> instead of null ... so we don't have to test for null every bloody time we use
> modifiers?

I would like that as well.