Issue 10981050: Update co19 status

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10981050: Update co19 status (Closed)

Created:
8 years, 2 months ago by ahe

Modified:
8 years, 2 months ago

Reviewers:
ricow1, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update co19 status Committed: https://code.google.com/p/dart/source/detail?r=12944

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	dart/tests/co19/co19-dart2js.status	View		2 chunks	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM http://codereview.chromium.org/10981050/diff/1/dart/tests/co19/co19-dart2js.status File dart/tests/co19/co19-dart2js.status (right): http://codereview.chromium.org/10981050/diff/1/dart/tests/co19/co19-dart2js.status#newcode113 dart/tests/co19/co19-dart2js.status:113: LibTest/core/List/List_A04_t01: Fail # TODO(ahe): Please triage this failure. ...

8 years, 2 months ago (2012-09-27 08:32:28 UTC) #3

ahe

8 years, 2 months ago (2012-09-27 08:51:14 UTC) #4

http://codereview.chromium.org/10981050/diff/1/dart/tests/co19/co19-dart2js.s...
File dart/tests/co19/co19-dart2js.status (right):

http://codereview.chromium.org/10981050/diff/1/dart/tests/co19/co19-dart2js.s...
dart/tests/co19/co19-dart2js.status:113: LibTest/core/List/List_A04_t01: Fail #
TODO(ahe): Please triage this failure.
On 2012/09/27 08:32:29, ngeoffray wrote:
> It is a co19 issue 224 still. In non-checked mode, it tries to catch an
> IllegalArgumentException, which got renamed to IllegalArgumentError.

Thank you. I think that bug is fixed, and should stop failing next time I update
co19.

Expand Messages | Collapse Messages