Convert raw strings in pub (and apidoc) to new syntax.

Convert raw strings in pub (and apidoc) to new syntax.

Committed: https://code.google.com/p/dart/source/detail?r=12890

[nweiz, 2012-09-26 00:49:52]

lgtm

Should we maybe change these tests so that their behavior when passed a string
is to check for the existence of that string in the output, rather than doing an
exact match? That would make a lot of these regexps unnecessary.

https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_g...
File utils/tests/pub/pub_install_git_test.dart (right):

https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_g...
utils/tests/pub/pub_install_git_test.dart:125: error: const RegExp('^Package
"foo" doesn\'t have a '
Removing the escaping here is inconsistent with the style below where we use r
for "'", despite that having no sensitive characters. Either use r here or don't
use r there.

https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_g...
utils/tests/pub/pub_install_git_test.dart:126: 'pubspec.yaml file.'),
The '.'s here should be escaped.

https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_t...
File utils/tests/pub/pub_install_test.dart (right):

https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_t...
utils/tests/pub/pub_install_test.dart:18: error: const RegExp(r'^Could not find
a file named "pubspec.yaml"'),
This "." should be escaped.

[Bob Nystrom, 2012-09-26 01:14:42]

Thanks

https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_g...
File utils/tests/pub/pub_install_git_test.dart (right):

https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_g...
utils/tests/pub/pub_install_git_test.dart:125: error: const RegExp('^Package
"foo" doesn\'t have a '
On 2012/09/26 00:49:52, nweiz wrote:
> Removing the escaping here is inconsistent with the style below where we use r
> for "'", despite that having no sensitive characters. Either use r here or
don't
> use r there.

Done.

https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_g...
utils/tests/pub/pub_install_git_test.dart:126: 'pubspec.yaml file.'),
On 2012/09/26 00:49:52, nweiz wrote:
> The '.'s here should be escaped.

Done.

https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_t...
File utils/tests/pub/pub_install_test.dart (right):

https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_t...
utils/tests/pub/pub_install_test.dart:18: error: const RegExp(r'^Could not find
a file named "pubspec.yaml"'),
On 2012/09/26 00:49:52, nweiz wrote:
> This "." should be escaped.

Done.

[Bob Nystrom, 2012-09-26 01:15:43]

On 2012/09/26 00:49:52, nweiz wrote:
> lgtm
> 
> Should we maybe change these tests so that their behavior when passed a string
> is to check for the existence of that string in the output, rather than doing
an
> exact match? That would make a lot of these regexps unnecessary.

I think it's still helpful to validate that it doesn't print extraneous stuff.
For example, I think we have tests that you *don't* get a warning if the root
package doesn't contain a lib directory. But we should definitely be able to
come up with something to simplify these.

> 
>
https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_g...
> File utils/tests/pub/pub_install_git_test.dart (right):
> 
>
https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_g...
> utils/tests/pub/pub_install_git_test.dart:125: error: const RegExp('^Package
> "foo" doesn\'t have a '
> Removing the escaping here is inconsistent with the style below where we use r
> for "'", despite that having no sensitive characters. Either use r here or
don't
> use r there.
> 
>
https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_g...
> utils/tests/pub/pub_install_git_test.dart:126: 'pubspec.yaml file.'),
> The '.'s here should be escaped.
> 
>
https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_t...
> File utils/tests/pub/pub_install_test.dart (right):
> 
>
https://codereview.chromium.org/10981031/diff/1/utils/tests/pub/pub_install_t...
> utils/tests/pub/pub_install_test.dart:18: error: const RegExp(r'^Could not
find
> a file named "pubspec.yaml"'),
> This "." should be escaped.