Issue 1098073003: Revert "Enforce token syntax for CssClassSet arguments"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1098073003: Revert "Enforce token syntax for CssClassSet arguments" (Closed)

Created:
5 years, 8 months ago by sra1

Modified:
5 years, 8 months ago

Reviewers:
terry

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Revert "Enforce token syntax for CssClassSet arguments" Committed: https://code.google.com/p/dart/source/detail?r=45302

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -164 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	4 chunks	+6 lines, -30 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	4 chunks	+6 lines, -30 lines	0 comments	Download
M	sdk/lib/html/html_common/css_class_set.dart	View	7 chunks	+3 lines, -17 lines	0 comments	Download
M	tests/html/element_classes_test.dart	View	4 chunks	+0 lines, -31 lines	0 comments	Download
M	tests/html/svgelement_test.dart	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	tools/dom/src/CssClassSet.dart	View	4 chunks	+6 lines, -30 lines	0 comments	Download

Total messages: 4 (1 generated)

sra1

The regexps should have been static. Reverting and I will re-commit for a clean cherry-pick.

5 years, 8 months ago (2015-04-21 00:25:27 UTC) #1

sra1

5 years, 8 months ago (2015-04-21 00:26:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45302 (presubmit successful).