Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 10979063: Removing ElementList. (Closed)

Created:
8 years, 2 months ago by blois
Modified:
8 years, 2 months ago
Reviewers:
vsm, Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removing ElementList (splitting out removing NodeList into a separate CL). BUG=2712 Committed: https://code.google.com/p/dart/source/detail?r=13076

Patch Set 1 #

Patch Set 2 : Removing ElementList. #

Patch Set 3 : Syncing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -241 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 22 chunks +31 lines, -63 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 21 chunks +29 lines, -62 lines 0 comments Download
M lib/html/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/templates/html/dartium/html_dartium.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/html/templates/html/impl/impl_DocumentFragment.darttemplate View 5 chunks +13 lines, -17 lines 0 comments Download
M lib/html/templates/html/impl/impl_Element.darttemplate View 9 chunks +10 lines, -23 lines 0 comments Download
M lib/html/templates/html/impl/impl_NodeList.darttemplate View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/html/templates/html/impl/impl_SVGElement.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/html/templates/html/interface/interface_Element.darttemplate View 2 chunks +1 line, -16 lines 0 comments Download
M tests/html/documentfragment_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/html/element_test.dart View 8 chunks +9 lines, -23 lines 0 comments Download
M tests/html/htmlcollection_test.dart View 11 chunks +24 lines, -24 lines 0 comments Download
M tests/html/node_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
8 years, 2 months ago (2012-09-28 00:52:50 UTC) #1
vsm
lgtm! As you land this, can you send out a breaking change notice to misc? ...
8 years, 2 months ago (2012-09-28 15:25:07 UTC) #2
Emily Fortuna
8 years, 2 months ago (2012-09-28 18:54:30 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698