- Implement first class types in the VM.

- Implement first class types in the VM.
- Make AbstractType a subclass of Instance and map it and its subclasses
  to private Dart classes in dart:core implementing the Type interface.
- Avoid dispatching through statics in Object if not strictly needed.
Committed: https://code.google.com/p/dart/source/detail?r=12981

[regis, 2012-09-27 21:12:40]

LGTM

That was simpler than I expected. Very cool!

https://codereview.chromium.org/10979058/diff/1/runtime/lib/object.cc
File runtime/lib/object.cc (right):

https://codereview.chromium.org/10979058/diff/1/runtime/lib/object.cc#newcode68
runtime/lib/object.cc:68: return type.Name();
You may consider returning UserVisibleName() instead of Name().

[Ivan Posva, 2012-09-27 21:25:12]

https://codereview.chromium.org/10979058/diff/1/runtime/lib/object.cc
File runtime/lib/object.cc (right):

https://codereview.chromium.org/10979058/diff/1/runtime/lib/object.cc#newcode68
runtime/lib/object.cc:68: return type.Name();
On 2012/09/27 21:12:40, regis wrote:
> You may consider returning UserVisibleName() instead of Name().

I specifically chose Name and not UserVisibleName to avoid the confusion when
for example "int" is not the same as "int" since we have two different actual
int types.

[regis, 2012-09-27 21:30:24]

On 2012/09/27 21:25:12, Ivan Posva wrote:
> https://codereview.chromium.org/10979058/diff/1/runtime/lib/object.cc
> File runtime/lib/object.cc (right):
> 
>
https://codereview.chromium.org/10979058/diff/1/runtime/lib/object.cc#newcode68
> runtime/lib/object.cc:68: return type.Name();
> On 2012/09/27 21:12:40, regis wrote:
> > You may consider returning UserVisibleName() instead of Name().
> 
> I specifically chose Name and not UserVisibleName to avoid the confusion when
> for example "int" is not the same as "int" since we have two different actual
> int types.

As long as you are aware of the difference, I am fine with your chosen flavor.
Name() is definitely more accurate, since it does not map any type name, but may
be more confusing to the average user. I suppose that users who will use this
functionality understand that we have implementation types.