Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 10979013: Issue 5292. Unreferenced imported identifiers should not be an error (Closed)

Created:
8 years, 2 months ago by scheglov
Modified:
8 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 5292. Unreferenced imported identifiers should not be an error http://code.google.com/p/dart/issues/detail?id=5292 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12847

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -62 lines) Patch
A + compiler/java/com/google/dart/compiler/resolver/DuplicateElement.java View 1 chunk +5 lines, -4 lines 0 comments Download
A compiler/java/com/google/dart/compiler/resolver/DuplicateElementImplementation.java View 1 chunk +88 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ElementKind.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 1 chunk +4 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java View 3 chunks +3 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java View 7 chunks +22 lines, -9 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java View 4 chunks +7 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 8 chunks +25 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java View 2 chunks +2 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java View 3 chunks +24 lines, -23 lines 2 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java View 2 chunks +84 lines, -15 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 2 months ago (2012-09-25 03:24:33 UTC) #1
Brian Wilkerson
8 years, 2 months ago (2012-09-25 13:11:20 UTC) #2
LGTM

https://codereview.chromium.org/10979013/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java
(right):

https://codereview.chromium.org/10979013/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java:158:
//  private static void
reportDuplicateTopLevelDeclarationImport(DartCompilerListener listener,
Unless there is a reason to keep this code, let's remove it.

https://codereview.chromium.org/10979013/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java:231:
//    // Getter/setter can shared same name, but not setter/setter and
getter/getter.
Unless there is a reason to keep this code, let's remove it (and the comment
after it).

Powered by Google App Engine
This is Rietveld 408576698