Issue 10978043: Made parsePrecedenceExpression not take an optional argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10978043: Made parsePrecedenceExpression not take an optional argument. (Closed)

Created:
8 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 2 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Made parsePrecedenceExpression not take an optional argument. Committed: https://code.google.com/p/dart/source/detail?r=12906

Patch Set 2 : Address review comments. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -14 lines)			Patch
	M	lib/compiler/implementation/scanner/parser.dart	View	1	8 chunks	+12 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM http://codereview.chromium.org/10978043/diff/1/lib/compiler/implementation/scanner/parser.dart File lib/compiler/implementation/scanner/parser.dart (right): http://codereview.chromium.org/10978043/diff/1/lib/compiler/implementation/scanner/parser.dart#newcode1192 lib/compiler/implementation/scanner/parser.dart:1192: bool allowCascades = true; I don't think this ...

8 years, 2 months ago (2012-09-26 12:12:59 UTC) #2

Lasse Reichstein Nielsen

8 years, 2 months ago (2012-09-26 12:48:43 UTC) #3

http://codereview.chromium.org/10978043/diff/1/lib/compiler/implementation/sc...
File lib/compiler/implementation/scanner/parser.dart (right):

http://codereview.chromium.org/10978043/diff/1/lib/compiler/implementation/sc...
lib/compiler/implementation/scanner/parser.dart:1192: bool allowCascades = true;
Removed.

http://codereview.chromium.org/10978043/diff/1/lib/compiler/implementation/sc...
lib/compiler/implementation/scanner/parser.dart:1198: bool allowCascades =
false;
And ditto too.

Expand Messages | Collapse Messages

Issue 10978043: Made parsePrecedenceExpression not take an optional argument. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comments. #

Messages