Issue 10978017: Make sure we can use JavaScript properties on Object as classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10978017: Make sure we can use JavaScript properties on Object as classes. (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make sure we can use JavaScript properties on Object as classes. Committed: https://code.google.com/p/dart/source/detail?r=12829

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -5 lines)			Patch
	M	lib/compiler/implementation/js_backend/emitter.dart	View	1	3 chunks	+6 lines, -5 lines	0 comments	Download
	A	tests/language/js_properties_test.dart	View		1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/10978017/diff/1/lib/compiler/implementation/js_backend/emitter.dart File lib/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/10978017/diff/1/lib/compiler/implementation/js_backend/emitter.dart#newcode198 lib/compiler/implementation/js_backend/emitter.dart:198: if (Object.prototype.hasOwnProperty.call(collectedClasses, cls)) { Move hasOwnProperty variable before ...

8 years, 3 months ago (2012-09-25 08:30:53 UTC) #2

ngeoffray

8 years, 3 months ago (2012-09-25 08:32:28 UTC) #3

Thanks Lasse

https://codereview.chromium.org/10978017/diff/1/lib/compiler/implementation/j...
File lib/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/10978017/diff/1/lib/compiler/implementation/j...
lib/compiler/implementation/js_backend/emitter.dart:198: if
(Object.prototype.hasOwnProperty.call(collectedClasses, cls)) {
On 2012/09/25 08:30:53, Lasse Reichstein Nielsen wrote:
> Move hasOwnProperty variable before this use too?

Done.

https://codereview.chromium.org/10978017/diff/1/lib/compiler/implementation/j...
lib/compiler/implementation/js_backend/emitter.dart:212: var hasOwnProperty =
Object.prototype.hasOwnProperty;
On 2012/09/25 08:30:53, Lasse Reichstein Nielsen wrote:
> indentation?

Done.

Expand Messages | Collapse Messages

Issue 10978017: Make sure we can use JavaScript properties on Object as classes. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages